A message forum for general discussion. Please come and chat with others!
There is an old saying "Practice makes perfect" but that's not quite true - "Perfect practice makes perfect" is more accurate. What you practice needs to be good quality and needs to improve.
So to be a good writer, you need to write and write a lot. And take any feedback you can get, as Tobber said. Not the feedback from friends and relatives who tell you everything is wonderful, but honest, real feedback. Use it to get better.
And read. A lot. The more you read from a variety of writers, the more you will come to see what works and what doesn't, what you like, what can inform your writing.
And, yes, do not give up. If some-one tells you a story is complete rubbish, don't throw it in. Ask them why. Use that to improve. Keep on writing. Perfect practice makes perfect.
And I'll add: Believe in yourself.